To use Marshal.ReleaseComObject or not to use

Status
Not open for further replies.
J

j

Hi,

I have shared addIn (.net 2.0, c#)

I add custom fields to mailItem object.

Please have a look in a code snippet below:

> .....

> ......

foreach (XmlNode field in fieldList)

{

fieldName = GetFieldName(field);

fieldValue = GetFieldValue(field);

try

{

AddCustomField(mailItem, fieldName, fieldValue);

}

catch (Exception ex)

{ // log }

}

> ....

void AddCustomField(Outlook.MailItem mailItem, string fieldName,

string fieldValue)

{

Outlook.UserProperties ups = mailItem.UserProperties;

SetUserProperty(ups, fieldName, typeof(string), fieldValue);//

adds field to mailItem

Marshal.ReleaseComObject(ups);

ups = null;

}

The question is:

I add a few custom fields to mailItem in a loop, do i need to release

ups (Outlook.UserProperties)?

Can this to destroy com object (mailItem) ??

Thanks in advance.
 
Releasing "ups" will not release the mail item, only the UserProperties

object.

If you're doing this in a loop then I would use Marshal.ReleaseComObject()

so you know when the objects are released. If this is being done only a few

times I wouldn't bother since the objects will be garbage collected at some

point in time after the procedure where they are in scope ends.

You always need to balance the perf hit of using Marshal.ReleaseComObject()

and GC.Collect() against the need to know that certain objects have been

released or to prevent the build-up of objects counting against the Exchange

open RPC channel limits.

"j" <evgeny.br@gmail.com> wrote in message

news:643344bd-ed69-4746-b7fd-5b8cd74447d0@32g2000yqj.googlegroups.com...
> Hi,

> I have shared addIn (.net 2.0, c#)

> I add custom fields to mailItem object.
> Please have a look in a code snippet below:

> .....
> ......
> foreach (XmlNode field in fieldList)
> {
> fieldName = GetFieldName(field);
> fieldValue = GetFieldValue(field);
> try
> {
> AddCustomField(mailItem, fieldName, fieldValue);
> }
> catch (Exception ex)
> { // log }
> }

> ....
> void AddCustomField(Outlook.MailItem mailItem, string fieldName,
> string fieldValue)
> {
> Outlook.UserProperties ups = mailItem.UserProperties;
> SetUserProperty(ups, fieldName, typeof(string), fieldValue);//
> adds field to mailItem

> Marshal.ReleaseComObject(ups);
> ups = null;
> }

> The question is:
> I add a few custom fields to mailItem in a loop, do i need to release
> ups (Outlook.UserProperties)?
> Can this to destroy com object (mailItem) ??

> Thanks in advance.
 
On Aug 26, 4:40 pm, "
<kenslo...@mvps.org> wrote:
> Releasing "ups" will not release the mail item, only the UserProperties
> object.

> If you're doing this in a loop then I would use Marshal.ReleaseComObject()
> so you know when the objects are released. If this is being done only a few
> times I wouldn't bother since the objects will be garbage collected at some
> point in time after the procedure where they are in scope ends.

> You always need to balance the perf hit of using Marshal.ReleaseComObject()
> and GC.Collect() against the need to know that certain objects have been
> released or to prevent the build-up of objects counting against the Exchange
> open RPC channel limits.

> >

> http://www.slovaktech.com

> "j" <evgeny...@gmail.com> wrote in message

> news:643344bd-ed69-4746-b7fd-5b8cd74447d0@32g2000yqj.googlegroups.com...

>
> > Hi,

>
> > I have shared addIn (.net 2.0, c#)

>
> > I add custom fields to mailItem object.
> > Please have a look in a code snippet below:

>
> > .....
> > ......
> > foreach (XmlNode field in fieldList)
> > {
> >      fieldName = GetFieldName(field);
> >      fieldValue = GetFieldValue(field);
> >      try
> >      {
> >             AddCustomField(mailItem, fieldName, fieldValue);
> >      }
> >      catch (Exception ex)
> >     {   // log }
> > }

>
> > ....
> > void  AddCustomField(Outlook.MailItem mailItem, string fieldName,
> > string fieldValue)
> > {
> >     Outlook.UserProperties ups = mailItem.UserProperties;
> >      SetUserProperty(ups, fieldName, typeof(string), fieldValue);//
> > adds field to mailItem

>
> >      Marshal.ReleaseComObject(ups);
> >      ups = null;
> > }

>
> > The question is:
> > I add a few custom fields to mailItem in a loop, do i need to release
> > ups (Outlook.UserProperties)?
> > Can this to destroy com object (mailItem) ??

>
> > Thanks in advance.-




Thanks,

Of cause i understand that releasing "ups" will not relese the

mailItem.

So i wanted to know whether i need to release the "ups"???, btw after

the loop i also releasing the mailItem.

What do you say??
 
If "ups" has not been released yet by the time you try to release the parent

mail item then releasing the parent mail item will fail (not with an error,

but by not releasing that object). So you have to judge that in your

decision.

"j" <evgeny.br@gmail.com> wrote in message

news:4904af04-4f3d-4a6d-b3d1-e08b9b891ddc@o15g2000yqm.googlegroups.com...

<snip
Thanks,

Of cause i understand that releasing "ups" will not relese the

mailItem.

So i wanted to know whether i need to release the "ups"???, btw after

the loop i also releasing the mailItem.

What do you say??
 
Status
Not open for further replies.
Back
Top